Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed docker-dde sample #2346

Merged
merged 1 commit into from
Jul 27, 2022
Merged

Removed docker-dde sample #2346

merged 1 commit into from
Jul 27, 2022

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Jul 26, 2022

Description (*)

This was added (by me) because of some missing features of ddev at this time. I'd drop it in favour of DDEV now.

Questions or comments

README.md should be updated for DDEV to provide some information how to completly setup a new project ...

  • use an existing DB
  • install with and without sample data

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions

This comment has been minimized.

@sreichel sreichel merged commit 1ae890b into 1.9.4.x Jul 27, 2022
@sreichel sreichel deleted the remove-dde branch July 27, 2022 11:07
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 1ae890b. ± Comparison against base commit 39425d9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants