Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capitalization Adjustment Regarding CamelCase in Method Names #2365

Merged
merged 4 commits into from
Aug 5, 2022
Merged

Capitalization Adjustment Regarding CamelCase in Method Names #2365

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7900fce
refactor: Adjusted capitalization of two public methods.
Sdfendor Aug 4, 2022
0a9926b
refactor: Adjusted capitalization of one protected method.
Sdfendor Aug 4, 2022
bd8b40c
refactor: Adjusted capitalization of where call.
Sdfendor Aug 4, 2022
19db611
chore: Removed fixed error from phpstan baseline.
Sdfendor Aug 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/code/core/Mage/Catalog/Block/Category/View.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ protected function _prepareLayout()
/*
want to show rss feed in the url
*/
if ($this->IsRssCatalogEnable() && $this->IsTopCategory()) {
if ($this->isRssCatalogEnable() && $this->isTopCategory()) {
$title = $this->helper('rss')->__('%s RSS Feed', $this->getCurrentCategory()->getName());
$headBlock->addItem('rss', $this->getRssLink(), 'title="'.$title.'"');
}
Expand All @@ -72,15 +72,15 @@ protected function _prepareLayout()
/**
* @return string
*/
public function IsRssCatalogEnable()
public function isRssCatalogEnable()
{
return Mage::getStoreConfig('rss/catalog/category');
}

/**
* @return bool
*/
public function IsTopCategory()
public function isTopCategory()
{
return $this->getCurrentCategory()->getLevel()==2;
}
Expand Down
2 changes: 1 addition & 1 deletion app/code/core/Mage/Newsletter/Model/Resource/Subscriber.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ public function loadByCustomer(Mage_Customer_Model_Customer $customer)
$select = $this->_read->select()
->from($this->getMainTable())
->where('subscriber_email=:subscriber_email')
->Where('store_id=:store_id');
->where('store_id=:store_id');

$result = $this->_read->fetchRow(
$select,
Expand Down
4 changes: 2 additions & 2 deletions app/design/frontend/base/default/template/catalog/category/view.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
/**
* Category view template
*
* @see Mage_Catalog_Block_Category_View
* @var Mage_Catalog_Block_Category_View $this
*/
?>
<?php
Expand All @@ -41,7 +41,7 @@
}
?>
<div class="page-title category-title">
<?php if($this->IsRssCatalogEnable() && $this->IsTopCategory()): ?>
<?php if($this->isRssCatalogEnable() && $this->isTopCategory()): ?>
<a href="<?php echo $this->getRssLink() ?>" class="link-rss"><?php echo $this->__('Subscribe to RSS Feed') ?></a>
<?php endif ?>
<h1><?php echo $_helper->categoryAttribute($_category, $_category->getName(), 'name') ?></h1>
Expand Down
6 changes: 3 additions & 3 deletions lib/Varien/Io/File.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ public function streamClose()
if ($this->_streamLocked) {
$this->streamUnlock();
}
if ($this->_IsValidSource($this->_streamHandler)) {
if ($this->_isValidSource($this->_streamHandler)) {
@fclose($this->_streamHandler);
}
$this->chmod($this->_streamFileName, $this->_streamChmod);
Expand Down Expand Up @@ -466,7 +466,7 @@ public function read($filename, $dest=null)
*/
public function write($filename, $src, $mode=null)
{
if (!$this->_IsValidSource($src) || !$this->_isFilenameWriteable($filename)) {
if (!$this->_isValidSource($src) || !$this->_isFilenameWriteable($filename)) {
return false;
}

Expand All @@ -491,7 +491,7 @@ public function write($filename, $src, $mode=null)
* @param string|resource $src
* @return bool
*/
protected function _IsValidSource($src)
protected function _isValidSource($src)
{
// In case of a string
if (is_string($src)) {
Expand Down