Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved phpseclib, mcrypt_compat, Cm_RedisSession, Cm_Cache_Backend_Redis and Pelago_Emogrifier to composer #2411

Merged
merged 33 commits into from
Dec 3, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
4381e83
Moved 3rd party libs to composer
fballiano Aug 11, 2022
ad9aac6
removed unused plugin
fballiano Aug 11, 2022
87a9ec5
removing autoloader patch
fballiano Aug 12, 2022
8cf3140
forced net_idna2 to a specific commit version
fballiano Aug 15, 2022
082fb4d
updated
fballiano Aug 15, 2022
27497e6
Replaced Net_IDNA with a more maintained polyfill
fballiano Aug 16, 2022
b6e8dde
Added scripts and deploy strategy
fballiano Aug 16, 2022
1f6d90d
partial rollback
fballiano Aug 16, 2022
5e76ce3
Merge branch '1.9.4.x' into composer_modules
fballiano Aug 22, 2022
a06ba6a
recalculated composer.lock
fballiano Aug 22, 2022
1d9a889
added cleanup script
fballiano Aug 24, 2022
e9bc022
Merge branch '1.9.4.x' into composer_modules
fballiano Aug 24, 2022
6f72b8f
dropped composer lock
fballiano Aug 28, 2022
fc15369
Merge branch '1.9.4.x' into composer_modules
fballiano Aug 28, 2022
1cdfc30
Merge branch '1.9.4.x' into composer_modules
fballiano Aug 28, 2022
e906adc
merge 19.4.x
fballiano Sep 26, 2022
e3d99a9
Removed Net IDN since ext-intl is now required
fballiano Sep 26, 2022
f1813f8
Restored 1.9.4.x version
fballiano Sep 26, 2022
ae1adc4
Restored 1.9.4.x version
fballiano Sep 26, 2022
f24e251
Merge branch '1.9.4.x' into composer_modules
fballiano Sep 26, 2022
fc9164c
Merge branch '1.9.4.x' into composer_modules
fballiano Sep 27, 2022
54fd649
addedcomposer lock
fballiano Sep 27, 2022
b5361a8
addedcomposer emogrifier
fballiano Sep 27, 2022
12db77c
Removed Pelago from our repo
fballiano Sep 27, 2022
038c445
Updated Emogrifier syntax for 6.0
fballiano Sep 27, 2022
0fe52e6
Merge branch '1.9.4.x' into composer_modules
fballiano Sep 28, 2022
6c2ab63
removed vendor cleaner plugin
fballiano Sep 28, 2022
21cc192
merged 1.9.4.x and regenerated composer.lock
fballiano Oct 30, 2022
4d05153
merged 1.9.4.x
fballiano Nov 15, 2022
3afe28d
Merge branch '1.9.4.x' into composer_modules
fballiano Nov 16, 2022
31430d0
merged 1.9.4.x and regenerated composer.lock
fballiano Dec 1, 2022
c39d1af
Merge branch '1.9.4.x' into composer_modules
fballiano Dec 2, 2022
ffaf954
updated composer
fballiano Dec 2, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions app/Mage.php
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,13 @@

Varien_Autoload::register();

include_once "phpseclib/bootstrap.php";
include_once "mcryptcompat/mcrypt.php";
/** AUTOLOADER PATCH **/
if (file_exists($autoloaderPath = BP . DS . 'vendor/autoload.php') ||
file_exists($autoloaderPath = BP . DS . '../vendor/autoload.php')
) {
require $autoloaderPath;
}
/** AUTOLOADER PATCH **/
fballiano marked this conversation as resolved.
Show resolved Hide resolved

/* Support additional includes, such as composer's vendor/autoload.php files */
foreach (glob(BP . DS . 'app' . DS . 'etc' . DS . 'includes' . DS . '*.php') as $path) {
Expand Down
695 changes: 0 additions & 695 deletions app/code/community/Cm/RedisSession/Model/Session.php

This file was deleted.

48 changes: 0 additions & 48 deletions app/code/community/Cm/RedisSession/etc/config.xml

This file was deleted.

11 changes: 4 additions & 7 deletions app/code/core/Mage/Core/Model/Email/Template/Abstract.php
Original file line number Diff line number Diff line change
Expand Up @@ -197,13 +197,10 @@ protected function _applyInlineCss($html)
// Only run Emogrify if HTML exists
if (strlen($html) && $inlineCssFile) {
$cssToInline = $this->_getCssFileContent($inlineCssFile);
$emogrifier = new Pelago_Emogrifier();
$emogrifier->setHtml($html);
$emogrifier->setCss($cssToInline);
// Don't parse inline <style> tags, since existing tag is intentionally for no-inline styles
$emogrifier->setParseInlineStyleTags(false);

$processedHtml = $emogrifier->emogrify();
$emogrifier = \Pelago\Emogrifier\CssInliner::fromHtml($html)
->inlineCss($cssToInline)
->disableInlineStyleAttributesParsing();
$processedHtml = $emogrifier->render();
} else {
$processedHtml = $html;
}
Expand Down
8 changes: 0 additions & 8 deletions app/etc/modules/Cm_RedisSession.xml

This file was deleted.

7 changes: 6 additions & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,12 @@
"ext-simplexml": "*",
"ext-soap": "*",
"ext-zlib": "*",
"magento-hackathon/magento-composer-installer": "^3.1 || ^2.1 || ^4.0"
"colinmollenhour/cache-backend-redis": "^1.14",
"colinmollenhour/magento-redis-session": "^3.0",
"magento-hackathon/magento-composer-installer": "^3.1 || ^2.1 || ^4.0",
"pelago/emogrifier": "^6.0",
"phpseclib/mcrypt_compat": "^2.0.3",
"phpseclib/phpseclib": "^3.0.14"
},
"require-dev": {
"dealerdirect/phpcodesniffer-composer-installer": "^0.7.2",
Expand Down
Loading