Fixed PHPStan error with Mage_Catalog_Model_Resource_Product_Option_Collection #2572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiatng
reviewed
Sep 7, 2022
app/code/core/Mage/Catalog/Model/Resource/Product/Option/Collection.php
Outdated
Show resolved
Hide resolved
elidrissidev
previously approved these changes
Sep 7, 2022
|
I found where it originated and fixed it reverting previous commits |
elidrissidev
approved these changes
Sep 7, 2022
addison74
approved these changes
Sep 7, 2022
|
All Green. |
|
yeah, i was waiting for the checks to end :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered in #2562 by @elidrissidev, it shouldn't be caused with that PR but anyway this PR should fix it.
Let's see if all lights are gree.