Fix unlink no such file or directory #2675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: lib/Varien
|
Cool website 👀 😉 |
elidrissidev
reviewed
Nov 8, 2022
| @@ -377,6 +377,7 @@ public function rmdir($dir, $recursive = false) | |||
| */ | |||
| public static function rmdirRecursive($dir, $recursive = true) | |||
| { | |||
| $result = true; | |||
There was a problem hiding this comment.
Since unlink was returning false when it can't find the file, shouldn't we switch this to false?
There was a problem hiding this comment.
If there are nothing to remove, I think it's good to return true.
fballiano
approved these changes
Jan 13, 2023
addison74
approved these changes
Jan 13, 2023
fballiano
pushed a commit
that referenced
this pull request
Jan 13, 2023
|
merged and cherrypicked to v20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sometimes, when a folder is removed, an error occurred.
OpenMage 20.0.16 / PHP 8.0.25
Contribution checklist