Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce getId calls #2677

Merged
merged 1 commit into from
Nov 6, 2022
Merged

Reduce getId calls #2677

merged 1 commit into from
Nov 6, 2022

Conversation

luigifab
Copy link
Contributor

@luigifab luigifab commented Nov 6, 2022 •
edited
Loading

Description

This reduce number of getId() calls (found with Blackfire).

OpenMage 20.0.16 / PHP 8.0.25

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@github-actions github-actions bot added the Component: Catalog Relates to Mage_Catalog label Nov 6, 2022
@sreichel sreichel merged commit 46bf1a9 into OpenMage:1.9.4.x Nov 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2022

Unit Test Results

1 files  1 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌
7 runs  5 ✔️ 2 💤 0 ❌

Results for commit 46bf1a9.

@luigifab luigifab deleted the less-getid branch November 6, 2022 19:44
@luigifab luigifab mentioned this pull request Nov 8, 2022
Merged
3 tasks
@luigifab luigifab mentioned this pull request Jan 17, 2023
Merged
4 tasks
@luigifab luigifab mentioned this pull request Feb 2, 2023
Merged
4 tasks
This was referenced Apr 9, 2023
Merged
Merged
@luigifab luigifab mentioned this pull request Apr 18, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sreichel sreichel sreichel approved these changes

@kiatng kiatng kiatng approved these changes

@fballiano fballiano fballiano approved these changes

Assignees
No one assigned
Labels
Component: Catalog Relates to Mage_Catalog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@luigifab @fballiano @kiatng @sreichel