Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set php version for phpstan #2692

Merged
merged 1 commit into from
Nov 8, 2022
Merged

Set php version for phpstan #2692

merged 1 commit into from
Nov 8, 2022

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Nov 7, 2022 •
edited
Loading

Description (*)

Ignore local php version ... (github uses php8, if using php7 results are different)

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@fballiano fballiano merged commit b191ddc into OpenMage:1.9.4.x Nov 8, 2022
@sreichel sreichel deleted the phpstan/fix-phpversion branch November 18, 2022 17:50
@sreichel sreichel mentioned this pull request Dec 27, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addison74 addison74 addison74 approved these changes

@fballiano fballiano fballiano approved these changes

Assignees
No one assigned
Labels
environment phpstan
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sreichel @fballiano @addison74