Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHPStan: Level 0 update #2794

Merged
merged 1 commit into from
Dec 9, 2022
Merged

PHPStan: Level 0 update #2794

merged 1 commit into from
Dec 9, 2022

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Dec 9, 2022 •
edited
Loading

Description (*)

We use phpstan with level 5, but there are still level 0 error that are not fixed. Fixed some.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added Component: Adminhtml Relates to Mage_Adminhtml Component: Api2 Relates to Mage_Api2 Component: Authorizenet Relates to Mage_Authorizenet Component: Bundle Relates to Mage_Bundle Component: Checkout Relates to Mage_Checkout Component: Customer Relates to Mage_Customer Component: Index Relates to Mage_Index Component: lib/Varien Relates to lib/Varien Component: lib/* Relates to lib/* Component: PayPal Relates to Mage_Paypal Component: Sales Relates to Mage_Sales Component: SalesRule Relates to Mage_SalesRule Component: Usa Relates to Mage_Usa Component: Weee Relates to Mage_Weee Component: Wishlist Relates to Mage_Wishlist phpstan labels Dec 9, 2022
@fballiano fballiano merged commit 88ff1d4 into OpenMage:1.9.4.x Dec 9, 2022
@sreichel sreichel deleted the phpstan-l0 branch December 9, 2022 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addison74 addison74 addison74 approved these changes

@fballiano fballiano fballiano approved these changes

Assignees
No one assigned
Labels
Component: Adminhtml Relates to Mage_Adminhtml Component: Api2 Relates to Mage_Api2 Component: Authorizenet Relates to Mage_Authorizenet Component: Bundle Relates to Mage_Bundle Component: Checkout Relates to Mage_Checkout Component: Customer Relates to Mage_Customer Component: Index Relates to Mage_Index Component: lib/Varien Relates to lib/Varien Component: lib/* Relates to lib/* Component: PayPal Relates to Mage_Paypal Component: Sales Relates to Mage_Sales Component: SalesRule Relates to Mage_SalesRule Component: Usa Relates to Mage_Usa Component: Weee Relates to Mage_Weee Component: Wishlist Relates to Mage_Wishlist phpstan
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sreichel @fballiano @addison74