Optimisation for Varien_Object::_addFullNames

[AGelzer]

Description (*)

Optimization for Varien_Object::_addFullNames

• less code
• array_intersect_key with array_flip is faster than array_intersect with array_values
• avoid array_search
• Tested with PHP8.0 Openmage 19.4.20 => 3x faster (Test Object: Mage_CatalogInventory_Model_Stock_Item)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

• Thanks

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All automated tests passed successfully (all builds are green)
• Add yourself to contributors list

[sreichel]

Can you please add some information about tests or measurement?

Just did a quick test with xhprof on admin product edit page ... before and after change ...

Or ... here it is faster before ... Test

[AGelzer]

Can you please add some information about tests or measurement?

Just did a quick test with xhprof on admin product edit page ... before and after change ...

Or ... here it is faster before ...

Test

Hi Sven ,
Thanks for https://onlinephp.io and testing :)
3x faster refer to function performance.
New is faster: Test

[AGelzer]

Changes

• Added empty check for syncFieldsMap

Performance Tests:

Compare: Old/New, Empty/Not empty Map (PHP8.2, PHP8.1, PHP8.0, PHP7.4)

XHProf (system load depend)

• PHP 8.0.26
• Processor: 24 x AMD Ryzen 9 5900X 12 Core Processor
• OpenMage: 19.4.21 (1 x Category, 1 x Product (simple), Cache: activated)

[sreichel]

Dont know why i had different numbers on phponline yesterday, but LGTM.

[AGelzer]

@sreichel @fballiano thanks :)

@sreichel
scientific notation?

Execution time : 1.3113021850586E-5 seconds
Execution time : 4.0531158447266E-6 seconds

[sreichel]

scientific notation?

Yes. Didn't see it.

Just one question ... did you use some tools for xdebug camparison? (or changed URL manually?)

DDEV provides xhprof support, but only links to current report (if enabled).

Would be nice to get such diff "on click".

(https://github.com/SergeyRock/xhprof-admin)

[AGelzer]

I used phacility/xhprof with my quick & dirty changes