Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phpstan: added missing returns #2832

Merged
merged 3 commits into from
Dec 22, 2022
Merged

phpstan: added missing returns #2832

merged 3 commits into from
Dec 22, 2022

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Dec 21, 2022 •
edited
Loading

Description (*)

... to be compatible with parent method.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added Component: Adminhtml Relates to Mage_Adminhtml Component: Api2 Relates to Mage_Api2 Component: Bundle Relates to Mage_Bundle Component: Catalog Relates to Mage_Catalog Component: CatalogInventory Relates to Mage_CatalogInventory Component: Core Relates to Mage_Core Component: Dataflow Relates to Mage_Dataflow Component: Downloadable Relates to Mage_Downloadable Component: lib/Varien Relates to lib/Varien Component: lib/* Relates to lib/* Component: Oauth Relates to Mage_Oauth Component: PayPal Relates to Mage_Paypal Component: ProductAlert Relates to Mage_ProductAlert Component: Sales Relates to Mage_Sales Component: Shipping Relates to Mage_Shipping Component: Tax Relates to Mage_Tax Component: Weee Relates to Mage_Weee Component: Wishlist Relates to Mage_Wishlist phpstan labels Dec 21, 2022
@fballiano fballiano merged commit 2bd4e09 into OpenMage:1.9.4.x Dec 22, 2022
@sreichel sreichel deleted the phpstan/daily-1 branch December 22, 2022 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addison74 addison74 addison74 approved these changes

@fballiano fballiano fballiano approved these changes

Assignees
No one assigned
Labels
Component: Adminhtml Relates to Mage_Adminhtml Component: Api2 Relates to Mage_Api2 Component: Bundle Relates to Mage_Bundle Component: Catalog Relates to Mage_Catalog Component: CatalogInventory Relates to Mage_CatalogInventory Component: Core Relates to Mage_Core Component: Dataflow Relates to Mage_Dataflow Component: Downloadable Relates to Mage_Downloadable Component: lib/Varien Relates to lib/Varien Component: lib/* Relates to lib/* Component: Oauth Relates to Mage_Oauth Component: PayPal Relates to Mage_Paypal Component: ProductAlert Relates to Mage_ProductAlert Component: Sales Relates to Mage_Sales Component: Shipping Relates to Mage_Shipping Component: Tax Relates to Mage_Tax Component: Weee Relates to Mage_Weee Component: Wishlist Relates to Mage_Wishlist phpstan
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sreichel @fballiano @addison74