Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added getApplyTo() to Mage_Eav_Model_Entity_Attribute_Abstract. ref #2829 #2836

Merged
merged 1 commit into from
Dec 23, 2022
Merged

Added getApplyTo() to Mage_Eav_Model_Entity_Attribute_Abstract. ref #2829 #2836

merged 1 commit into from
Dec 23, 2022

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Dec 23, 2022 •
edited
Loading

Description (*)

Adds public function getApplyTo() method to abstract class, that is reused in child classes. (prevent return null)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes protected function _isApplicableAttribute #2829

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added Component: Catalog Relates to Mage_Catalog Component: Eav Relates to Mage_Eav labels Dec 23, 2022
@fballiano fballiano merged commit ea95c12 into OpenMage:1.9.4.x Dec 23, 2022
@sreichel sreichel deleted the test-2829 branch December 23, 2022 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addison74 addison74 addison74 approved these changes

@fballiano fballiano fballiano approved these changes

Assignees
No one assigned
Labels
Component: Catalog Relates to Mage_Catalog Component: Eav Relates to Mage_Eav
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

protected function _isApplicableAttribute
3 participants
@sreichel @fballiano @addison74