RWD theme: removed border bottom from h1/h2 #2920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addison74
changed the title
addison74
approved these changes
Jan 11, 2023
|
I actually didn’t check the mobile 🤦🏻♂️ sorry! Thanks @addison74 😊 |
kiatng
approved these changes
Jan 12, 2023
|
pushed this one to v20 (solving a conflict with a missing file, really easy): 4a2ab67 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was checkin the RWD theme and I noted that some pages have a
border-bottombelow the page title, like these:but most of them don't, like:
Since I find that there are too many borders and I think that it's ok to have separations between
header,contentandfooterbut inside the content we should avoid having too many borders, I made the pages look like this:removing the border-bottom from
.page-title. Hope you like the idea.