Fix HEADERS ALREADY SENT from Mage_Core_Block_Template #2978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fballiano
approved these changes
Jan 29, 2023
fballiano
added a commit
that referenced
this pull request
Feb 1, 2023
Co-authored-by: Fabrizio Balliano <[email protected]>
|
merged and v20ed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fix a little error introduced by #2623 (comment).
Manual testing scenario
Create an error in app/design/frontend/rwd/default/template/persistent/customer/form/login.phtml, for example add:
Mage::get();. Go to the customer login page.Before this PR, when developer is disabled:
Error: Call to undefined method Mage::get() in app/design/frontend/rwd/default/template/persistent/customer/form/login.phtml:22HEADERS ALREADY SENT: \<pre>[0] app/code/core/Mage/Core/Controller/Response/Http.php:45Apply the PR and try again, the system.log is not created.
Contribution checklist