Fix #3312 ExtJS Tree Checkbox Update #3314
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
PR #2473 upgraded ExtJS from 1.0.1 to 1.1.1, but there was a breaking change in that library. So, the
extjs-tree-checkbox.js
file needed to be updated. The checkbox tree file was not part of ExtJS, but a plugin that somebody wrote and included into Magento. Luckily, the author wrote a comment with the fix.Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
We have an alternate solution:
But I don't think it's necessary, since ExtJS renamed container -> innerCt. The above would only be necessary if we need to support someone who is still using ExtJS 1.0.1.
Contribution checklist (*)