Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed text-shadow from disabled dropdown in Admin #3583

Merged

Conversation

elidrissidev
Copy link
Member

Description (*)

Minor UX improvement to disabled dropdowns in Admin that removes text-shadow for better readability.

Before After
Screen Shot 2023-10-06 at 10 58 11 AM Screen Shot 2023-10-06 at 10 57 41 AM

Manual testing scenarios (*)

  1. Go to any admin page that has a disabled dropdown, example: Configuration -> Payment Methods -> Cash On Delivery Payment.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added Template : admin Relates to admin template Component: Adminhtml Relates to Mage_Adminhtml labels Oct 6, 2023
@addison74
Copy link
Contributor

Have you checked if it needs to be modified in any SCSS file?

OT: What a funny color value "#cacaca" chose the Magento team. This word in some languages means poop/shit.

@elidrissidev
Copy link
Member Author

Have you checked if it needs to be modified in any SCSS file?

Yes, the OM theme had no override for those styles.

@elidrissidev elidrissidev changed the title Remove text-shadow from disable dropdown in Admin Removed text-shadow from disabled dropdown in Admin Oct 6, 2023
@elidrissidev elidrissidev merged commit 6a3a92e into OpenMage:main Oct 6, 2023
3 checks passed
@elidrissidev elidrissidev deleted the improv/disabled-dropdown-textshadow branch October 6, 2023 19:24
@addison74
Copy link
Contributor

addison74 commented Jul 5, 2024

Even I approved this PR, I noticed that it creates issues. Below are screenshots that prove it. Aheadworks Z-Blocks extension relies on the "select.mutiselect option" in boxes.css.

If "Use parent values" is checked, you can see that the text is no longer visible.

screenshot_1

If "Use parent values" is unchecked then it becomes visible

screenshot_2

We should revert this PR or remove the color property / change the color value / add the background color e.g #fafafa, here is the effect below

screenshot_3

@addison74
Copy link
Contributor

addison74 commented Jul 5, 2024

This is how it looks the multiselect reverting this PR

screenshot_4

It is obvious that we did not check the scenario when all options are selected. When they are not selected the background is white, and when they are selected the background is gray. that shadow made the text visible.

@addison74
Copy link
Contributor

or we can use a soft shadow

text-shadow: 1px 1px 1px #000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Adminhtml Relates to Mage_Adminhtml enhancement Template : admin Relates to admin template
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants