Fixed a couple of null parameter warnings in the ImportExport module

[fballiano]

• Fixes Deprecated functionality: strlen(): Passing null to parameter #1 ($string) of type string is deprecated #3810
• Fixes Fatal error: Uncaught Error: Call to a member function addData() on null #3811

I created only one PR since both of the issues about about importexport

[kiatng]

We cannot assume $default is always an empty string.

Suggested change

	if ($value === null) {
	return '';
	}
	return $this->escapeHtml(strlen($value) > 0 ? $value : $default);
	return $value !== null && $this->escapeHtml(strlen($value) > 0 ? $value : $default);

[fballiano]

@kiatng true, I also did it in a previous PR but I didn't notice here :-D

I did it in a different way (more similar to the other one, for readability), what do you think?

thanks!!

[kiatng]

The comment should be above $data as it is related to it:

Suggested change

	// Set entered data if was error when we do save
	$profile = Mage::registry('current_convert_profile');
	// set entered data if was error when we do save
	$data = Mage::getSingleton('adminhtml/session')->getConvertProfileData(true);
	/** @var Mage_Dataflow_Model_Profile $profile */
	$profile = Mage::registry('current_convert_profile');
	// Repopulate user input values in the edit form in case of saving error
	$data = Mage::getSingleton('adminhtml/session')->getConvertProfileData(true);

[fballiano]

I reformatted it this way because it seems that comment belongs to this whole logical section:

I can revert it but those variables and that comment kinda belong together :-)

[kiatng]

I think #3811 is unrelated to null deprecation and should be a separate PR should it be a bug. At this point, I am not sure it is.

[fballiano]

I think #3811 is unrelated to null deprecation and should be a separate PR should it be a bug. At this point, I am not sure it is.

I just didn't want to create too many PRs in one go so I thought about merging at least the two that seemed a bit related to each other :-\

[addison74]

I just tested this PR.

Case 1
In the Advanced Profiles grid page, press the [Add New Profile] button. Then fill in "Profile Name" and "Actions XML" with some data. As soon as you press the [Save] button, you get the following error

Fatal error:  Uncaught Error: Call to a member function getId() on null in /var/www/html/app/code/core/Mage/Adminhtml/controllers/System/Convert/ProfileController.php:117
Stack trace:
#0 /var/www/html/app/code/core/Mage/Core/Controller/Varien/Action.php(421): Mage_Adminhtml_System_Convert_ProfileController->editAction()
#1 /var/www/html/app/code/core/Mage/Core/Controller/Varien/Router/Standard.php(255): Mage_Core_Controller_Varien_Action->dispatch()
#2 /var/www/html/app/code/core/Mage/Core/Controller/Varien/Front.php(181): Mage_Core_Controller_Varien_Router_Standard->match()
#3 /var/www/html/app/code/core/Mage/Core/Model/App.php(358): Mage_Core_Controller_Varien_Front->dispatch()
#4 /var/www/html/app/Mage.php(760): Mage_Core_Model_App->run()
#5 /var/www/html/index.php(56): Mage::run()
#6 {main}
  thrown in /var/www/html/app/code/core/Mage/Adminhtml/controllers/System/Convert/ProfileController.php on line 117

Case 2
In my case there is already a profile in the grid and I will edit it. In the editing page, press any of the [Save Profile] or [Save and Continue Edit] buttons and the following message is displayed

There are two files affected if this PR is merged.

[addison74]

This PR must be split into two because it does not solve any of the reported problems.

In the case of the Profiles grid. Press the [Add New Profiles] button. Fill in "Name" and press the [Save and Continue Edit] button. The following error appears at the top