Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed deprecated and unused files from lib/Mage #3872

Merged
merged 6 commits into from
Apr 8, 2024
Merged

Removed deprecated and unused files from lib/Mage #3872

merged 6 commits into from
Apr 8, 2024

Conversation

fballiano
Copy link
Contributor

@fballiano fballiano commented Mar 5, 2024

THIS PR TARGETS V21

These files seem to be unused (unreferenced anywhere).
lib/Mage/Cache/Backend/Redis.php is also deprecated since many years (I've tested redis cache without this file and it works perfectly)

@github-actions github-actions bot added Component: lib/Mage Relates to lib/Mage Component: lib/* Relates to lib/* labels Mar 5, 2024
@kiatng
Copy link
Contributor

kiatng commented Mar 6, 2024

There may be local.xml with this setting:

<backend>Mage_Cache_Backend_Redis</backend>

That needs to change to this after this PR:

<backend>Cm_Cache_Backend_Redis</backend>

Ref https://github.com/colinmollenhour/Cm_Cache_Backend_Redis.

@fballiano
Copy link
Contributor Author

I'll make sure to write that in the release notes for v21

@kiatng
Copy link
Contributor

kiatng commented Mar 7, 2024

Found this:

throw new Mage_DB_Exception(mysqli_connect_error($this->conn));

oops...it's circular reference in Mage_DB_Mysqli

@fballiano
Copy link
Contributor Author

exactly, that why I think it's time to clean out those files

@fballiano
Copy link
Contributor Author

note that the PR targets next

@fballiano fballiano requested review from kiatng, addison74 and a team April 5, 2024 12:51
@fballiano fballiano merged commit 9ffc7c1 into OpenMage:next Apr 8, 2024
17 checks passed
@fballiano fballiano deleted the removedfiles branch April 8, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: lib/Mage Relates to lib/Mage Component: lib/* Relates to lib/* phpstan
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants