Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrote js/mage/adminhtml/input-counter.js without prototypejs #3948

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Rewrote js/mage/adminhtml/input-counter.js without prototypejs #3948

merged 2 commits into from
Apr 30, 2024

Conversation

fballiano
Copy link
Contributor

This PR targets next

This was very hard to test, I couldn't find anywhere where this file would originally be used (it's included in the html but it doesn't seem to run anywhere).

So

  • I've created a product, with a "text" custom option, setting a maxlength for the custom option value
  • I've created an order, trying to add the product from above, when the "configure" popup is shown then I'd copy past the inner part of the code from this PR (without the first line window.addEventListener('DOMContentLoaded', function() {)

The code is working as expected, this is the countdown when the input is still valid
Screenshot 2024-04-21 alle 17 07 21

and this is when it becomes invalid
Screenshot 2024-04-21 alle 17 07 26

@github-actions github-actions bot added the JavaScript Relates to js/* label Apr 21, 2024
@fballiano fballiano changed the title Rewrote js/mage/adminhtml/input-counter.js without prototypejs Rewrote js/mage/adminhtml/input-counter.js without prototypejs Apr 21, 2024
@fballiano fballiano merged commit fc0305a into OpenMage:next Apr 30, 2024
14 checks passed
@fballiano fballiano deleted the rewroteinputcounter branch April 30, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JavaScript Relates to js/*
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants