Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Deprecated Global Translate Function "__()" #3953

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Remove Deprecated Global Translate Function "__()" #3953

merged 1 commit into from
Apr 23, 2024

Conversation

Sdfendor
Copy link
Contributor

Description (*)

Original PR #2333 has accidentally been deleted a while ago but the changes are still relevant.
PR now targets next branch.

Removes the global translation function being deprecated since 1.3 (March 2009). found one remnant usage in lib/Varien which has no corresponding translation string thus in my understanding doesn't work anyways. This ancient artifact shouldn't have a place in 21.x.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@github-actions github-actions bot added documentation environment Component: PayPal Relates to Mage_Paypal Component: Core Relates to Mage_Core Component: Catalog Relates to Mage_Catalog Template : admin Relates to admin template Component: Cms Relates to Mage_Cms Component: Reports Relates to Mage_Reports Component: CatalogInventory Relates to Mage_CatalogInventory Component: Checkout Relates to Mage_Checkout Component: AdminNotification Relates to Mage_AdminNotification Component: lib/Varien Relates to lib/Varien Component: Sales Relates to Mage_Sales Component: Usa Relates to Mage_Usa Component: Customer Relates to Mage_Customer Component: Eav Relates to Mage_Eav Template : rwd Relates to rwd template Component: lib/Mage Relates to lib/Mage Template : base Relates to base template Component: Adminhtml Relates to Mage_Adminhtml Component: ProductAlert Relates to Mage_ProductAlert Mage.php Relates to app/Mage.php Component: Sitemap Relates to Mage_Sitemap Component: Page Relates to Mage_Page Component: Api PageRelates to Mage_Api Component: Cron Relates to Mage_Cron Component: Contacts Relates to Mage_Contacts Component: Tag Relates to Mage_Tag Component: CatalogRule Relates to Mage_CatalogRule labels Apr 23, 2024
@luigifab luigifab removed Component: Rating Relates to Mage_Rating Component: Persistant Relates to Mage_Persistant Component: Oauth Relates to Mage_Oauth Component: Newsletter Relates to Mage_Newsletter Component: Index Relates to Mage_Index Component: Downloadable Relates to Mage_Downloadable Component: Bundle Relates to Mage_Bundle Component: CatalogIndex Relates to Mage_CatalogIndex Component: Sendfriend Relates to Mage_Sendfriend Component: Media Relates to Mage_Media Component: Log Relates to Mage_Log Component: ImportExport Relates to Mage_ImportExport Component: Directory Relates to Mage_Directory Component: CatalogSearch Relates to Mage_CatalogSearch shell Relates to shell scripts Component: Dataflow Relates to Mage_Dataflow Component: Install Relates to Mage_Install Component: Rss Relates to Mage_Rss Component: Paygate Relates to Mage_Paygate Component: lib/* Relates to lib/* translations Relates to app/locale composer Relates to composer.json JavaScript Relates to js/* XML Layout phpstan phpcs php-cs-fixer phpunit labels Apr 24, 2024
@Sdfendor Sdfendor restored the refactor-remove-global-translate branch May 8, 2024 11:40
@Sdfendor Sdfendor deleted the refactor-remove-global-translate branch May 8, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Component: Core Relates to Mage_Core Component: lib/Varien Relates to lib/Varien
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sdfendor @pquerner @fballiano @luigifab