In product list all swatches are always shown even if they are not available when "Display Out of Stock Products" is disabled

[empiricompany]

Description (*)

In the product list, all swatches are always shown even if they are not available.
You can verify this on the PDP because only the available ones are displayed correctly.

Tested with both enabled and disabled stock inventory configuration "Display Out of Stock Products"

When "Display Out of Stock Products" is enabled shown correctly like this:

When "Display Out of Stock Products" is disabled all swatches are always shown even if they are not available.
With this patch shown correctly like this:

The bug occurs when the " Display Out of Stock Products" configuration is disabled.

Related Pull Requests

Fixed Issues (if relevant)

#3527

Manual testing scenarios (*)

1. Create configurable product with options as swatch such as color
2. Set stock unavailable for one color option

Example with sample data:

1. In product configurable Name: "Nolita cami" SKU "wbk000c" set all children products with color pink unavailable.

In the product list, all colors are always shown even if they are not available.
You can verify this on the PDP because only the available ones are displayed correctly.

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All automated tests passed successfully (all builds are green)
• Add yourself to contributors list

[empiricompany]

Sorry @fballiano you can delete this #4099 please?

[fballiano]

@empiricompany as of today I'm no longer part of this project

[empiricompany]

@empiricompany as of today I'm no longer part of this project

What?? This is unacceptable, this project would have died without you! What did I miss?

[sreichel]

Smart change. 👍

What is this flag for? See https://magento.stackexchange.com/questions/106455/get-product-stock-quantity-in-magento/209510#209510.

@addison74 please test for #1694, too.

[addison74]

@sreichel - I will.

Please check this one #3527. It could be related too.

[kiatng]

Ref

magento-lts/app/code/core/Mage/CatalogInventory/Model/Observer.php

Lines 108 to 110 in 5d3af08

	if ($productCollection->hasFlag('require_stock_items')) {
	Mage::getModel('cataloginventory/stock')->addItemsToProducts($productCollection);
	} else {