Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phpstan fixes #4116

Merged
merged 7 commits into from
Jul 29, 2024
Merged

Phpstan fixes #4116

merged 7 commits into from
Jul 29, 2024

Conversation

sreichel
Copy link
Contributor

Description (*)

Mostly fixing docblock and adding a few inline docklocks and setting some default values.

* Rector: CQ - UnusedForeachValueToArrayKeysRector

See Rector\CodeQuality\Rector\Foreach_\UnusedForeachValueToArrayKeysRector

* fixes + phpstan

See fix at rector: rectorphp/rector-src#6164
@github-actions github-actions bot added Component: Usa Relates to Mage_Usa Component: Shipping Relates to Mage_Shipping Component: ImportExport Relates to Mage_ImportExport Component: Uploader Relates to Mage_Uploader phpstan labels Jul 24, 2024
Copy link
Contributor

@kiatng kiatng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sreichel sreichel merged commit cabdc8b into OpenMage:main Jul 29, 2024
17 checks passed
@sreichel sreichel deleted the phpstan-1 branch July 29, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: ImportExport Relates to Mage_ImportExport Component: Shipping Relates to Mage_Shipping Component: Uploader Relates to Mage_Uploader Component: Usa Relates to Mage_Usa phpstan
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants