Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issues #4134 undefined array index label_use_default in Mage_Catalog_Model_Product_Attribute_Backend_Media #4136

Merged
merged 5 commits into from
Sep 2, 2024

Conversation

empiricompany
Copy link
Contributor

@empiricompany empiricompany commented Aug 1, 2024

Description (*)

The error occurs only when creating a new product.
This patch skips the PR modification for supporting image labels in the case of a multistore (#2481) since there is no option to use the default label (the product must be created first) and executes the original code to avoid the error.

Related Pull Requests

#4024

Fixed Issues (if relevant)

  1. Fixes Error when saving product with image without description #4134

Manual testing scenarios (*)

  1. Create a new product
  2. Upload an image without a label
  3. Keep image label empty
  4. Set default for Base Image, Small Image and Thumbnail
  5. Save

I have also re-tested multistore labels #2481 and still works correctly.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added the Component: Catalog Relates to Mage_Catalog label Aug 1, 2024
@empiricompany empiricompany marked this pull request as ready for review August 1, 2024 07:36
Co-authored-by: kiatng
@kiatng kiatng merged commit 35f331b into OpenMage:main Sep 2, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Catalog Relates to Mage_Catalog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when saving product with image without description
4 participants