-
-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small DocBlock update #4160
Merged
Merged
Small DocBlock update #4160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rector: CQ - UnusedForeachValueToArrayKeysRector See Rector\CodeQuality\Rector\Foreach_\UnusedForeachValueToArrayKeysRector * fixes + phpstan See fix at rector: rectorphp/rector-src#6164
This reverts commit 3d7eaf6.
github-actions
bot
added
Component: Core
Relates to Mage_Core
Component: lib/Varien
Relates to lib/Varien
Component: Sales
Relates to Mage_Sales
Component: Adminhtml
Relates to Mage_Adminhtml
Component: SalesRule
Relates to Mage_SalesRule
Component: Tax
Relates to Mage_Tax
Component: Newsletter
Relates to Mage_Newsletter
Component: CatalogSearch
Relates to Mage_CatalogSearch
Component: lib/*
Relates to lib/*
labels
Aug 21, 2024
kiatng
reviewed
Aug 21, 2024
Co-authored-by: Ng Kiat Siong <[email protected]>
Co-authored-by: Ng Kiat Siong <[email protected]>
Co-authored-by: Ng Kiat Siong <[email protected]>
kiatng
approved these changes
Aug 22, 2024
addison74
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: Adminhtml
Relates to Mage_Adminhtml
Component: CatalogSearch
Relates to Mage_CatalogSearch
Component: Core
Relates to Mage_Core
Component: lib/Varien
Relates to lib/Varien
Component: lib/*
Relates to lib/*
Component: Newsletter
Relates to Mage_Newsletter
Component: Sales
Relates to Mage_Sales
Component: SalesRule
Relates to Mage_SalesRule
Component: Tax
Relates to Mage_Tax
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... detected with strict types on.