-
-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Admin config: added input validation & hide disabled options #4232
Conversation
please provide a description including the reason of this PR |
Nice work. This PR makes some changes in the Backend > System > Configuration. for example in Google Sitemap > CMS Pages Options section. If Frequency = "Do not show in sitemap" Priority and Show lastmod are displayed, although they should not be displayed. Before After Similarly in the same section for Generation Settings, if it is not enabled, its 5 options are no longer displayed. I will check all the sections so that nothing is omitted and then I will approve it. |
The following sections need an evaluation: Catalog > Catalog > Product Alerts Sales > Shipping Methods > UPS |
I have hidden the template selector.
The |
Just delete a node inside , for example the first one access_license_number, then reload the page. By setting "Enable for Checkout to No", all inputs disappear. There is something strange in the node. |
I think there is some javascript that disables the input for the 7 fields. I'd leave it as it is. |
Missed your last comment ... I have an idea. Will test it later. |
Can confirm deleting "access_license_number" works. Lets fix it another time. Create issue for it. |
Do not render options for disabled sections (e.g. disabled payment methods).
Added some input-validation to enforce number/digit imput.