Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color swatches work with disparate product IDs #497

Merged
merged 1 commit into from
May 26, 2022
Merged

Color swatches work with disparate product IDs #497

merged 1 commit into from
May 26, 2022

Commits on Jul 31, 2018

  1. Color swatches work with disparate product IDs

    There is a bug in ConfigurableSwatches module where product IDs are sorted numerically then compared alphabetically.
    For example, "2" is less than "10" numerically, but "2" is greater than "10" because it is also greater than "1" alphabetically.
    This led to cases where a child product with a shorter ID than it's siblings would break swatch switching for those parent products only.
    The bug was identified in https://magento.com/tech-resources/bug-tracking/issue/index/id/1305/ @ 2/15/2016
    
    This fix deprecates the buggy `ConfigurableMediaImages.arrayIntersect` method in favour of Prototype's `Array#intersect`
    clockworkgeek committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    28e7a75 View commit details
    Browse the repository at this point in the history