Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mage_Sendfriend - DOC block update #749

Merged
merged 3 commits into from
May 22, 2020
Merged

Mage_Sendfriend - DOC block update #749

merged 3 commits into from
May 22, 2020

Conversation

sreichel
Copy link
Contributor

  • doc blocks added/fixed
  • PSR2 fixes (whitespaces, linebreaks, ...)

@sreichel
Mage_Sendfriend - DOC block update
763f803 
- doc blocks added/fixed
- PSR2 fixes (whitespaces, linebreaks, ...)
@sreichel sreichel added the Cleanup: DOC blocks Related to DOC block updates and fixes. label Jun 20, 2019
Flyingmana
Flyingmana previously approved these changes Sep 21, 2019
View reviewed changes
@sreichel sreichel requested a review from tmotyl May 9, 2020 03:22
tmotyl
tmotyl previously approved these changes May 9, 2020
View reviewed changes
Copy link
Contributor

@tmotyl tmotyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve, but please create an issue for inconsisten and/or vs || &&

app/code/core/Mage/Sendfriend/Model/Sendfriend.php Outdated Show resolved Hide resolved
@sreichel sreichel dismissed stale reviews from tmotyl and Flyingmana via 7561cc9 May 10, 2020 01:33
@sreichel
Copy link
Contributor Author

sreichel commented May 10, 2020 •
edited
Loading

I approve, but please create an issue for inconsisten and/or vs || &&

I guess there are many occurrences ... i'll create a tickt for.

@sreichel sreichel mentioned this pull request May 10, 2020
Closed
6 tasks
tmotyl
tmotyl previously approved these changes May 10, 2020
View reviewed changes
Copy link
Contributor

@tmotyl tmotyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ive created an issue for fixing the logical operators #958

@colinmollenhour colinmollenhour merged commit e8bca3a into OpenMage:1.9.4.x May 22, 2020
@sreichel sreichel deleted the cleanup/sendfriend branch May 22, 2020 01:57
@sreichel sreichel added the Component: Sendfriend Relates to Mage_Sendfriend label Jun 5, 2020
@sreichel sreichel added this to the Release 19.4.4 milestone Jun 26, 2020
@sreichel sreichel mentioned this pull request Jun 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmotyl tmotyl tmotyl approved these changes

@colinmollenhour colinmollenhour colinmollenhour approved these changes

@Flyingmana Flyingmana Flyingmana left review comments

Assignees
No one assigned
Labels
Cleanup: DOC blocks Related to DOC block updates and fixes. Component: Sendfriend Relates to Mage_Sendfriend
Projects
None yet
Milestone
Release 19.4.4 / 20.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@sreichel @colinmollenhour @Flyingmana @tmotyl