Mage_Eav - DOC block update #771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- doc blocks added/fixed - PSR2 fixes (whitespaces, linebreaks, ...)
tmotyl
requested changes
May 11, 2020
app/code/core/Mage/Eav/Block/Adminhtml/Attribute/Edit/Main/Abstract.php
Outdated
Show resolved
Hide resolved
| @@ -1587,7 +1586,9 @@ public function saveAttribute(Varien_Object $object, $attributeCode) | |||
| /** | |||
| * Delete entity using current object's data | |||
| * | |||
| * @param object $object | |||
There was a problem hiding this comment.
int|string|Varien_Object? (numeric string?)
if (is_numeric($object)) {
$id = (int)$object;
There was a problem hiding this comment.
ok, but for clarity I would mark it as int|varien_object to encourage passing proper it, and in the longer run making core usge ints.
But lets get anything you also agrees with to keep it going. I think we will need few more rounds of doc fixes after this initial one.
6 tasks
tmotyl
previously approved these changes
May 16, 2020
Closed
colinmollenhour
previously approved these changes
Jun 10, 2020
colinmollenhour
approved these changes
Jun 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: todo replace
objectannotation with correct classes (round 2)