Updating API module #106
Updating API module #106
Conversation
AnHeuermann
commented
Oct 5, 2023
AnHeuermann
commented
- Adding ScriptingError error
- Throw errors instead of prints when failing
- special treatment of stopTime for API.simulate
- More documentation
- Adding ScriptingError error - Throw errors instead of prints when failing - special treatment of stopTime for API.simulate - More documentation
| if !isnothing(stopTime) | ||
| exp *= "stopTime = $stopTime," | ||
| end |
There was a problem hiding this comment.
This special treatment of stopTime is stupid, but I couldn't figure out a way to change this without changing omc itself. The scripting documentation in the User's Guide is wrong.
input Real stopTime = 1.0 "the stop time of the simulation. = 1.0";
The default value isn't 1.0 but the value specified in the experiment annotation. But there is no value one can provide to the scripting call to get the same behavior as not specifying stopTime.
| @@ -62,8 +106,12 @@ module API | |||
| ) | |||
|
|
|||
| exp = join(["loadFile", "(", "fileName", "=", modelicaString(fileName), ",", "encoding", "=", modelicaString(encoding), ",", "uses", "=", uses,",", "notify", "=", notify,",", "requireExactVersion", "=", requireExactVersion,")"]) | |||
| return sendExpression(omc, exp) | |||
| success = OMJulia.sendExpression(omc, exp) | |||
There was a problem hiding this comment.
@AnHeuermann I see that you are using a better error reporting, but in our mos scripts we always use getErrorString()
loadFile("XXX");
getErrorString();
but from users point of view the API should give error msg without the use of getErrorString()
|
|
