Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow parsing exceptions in failure #23

Merged
merged 1 commit into from
Aug 27, 2019

Conversation

arun3688
Copy link
Contributor

No description provided.

@arun3688 arun3688 requested a review from sjoelund August 27, 2019 11:50
Copy link
Member

@sjoelund sjoelund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not silently ignore parser errors. Call a different function instead if you just want the raw string returned. Otherwise we could silently return a string for something that should be an integer

@arun3688
Copy link
Contributor Author

@sjoelund , should we simply add a default flag "parsed=True" similar to OMPython and the user can explictity specify parsed = false incase of raw string

@sjoelund
Copy link
Member

We could do that, yes.

@sjoelund
Copy link
Member

I think it should be a keyword argument. Otherwise it's not visible what the last argument is doing since you cannot pass sendExpression(omc, cmd, parsed=false) now.

@arun3688 arun3688 merged commit ee363e4 into OpenModelica:master Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants