Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return error if CVODE failed #1214

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

AnHeuermann
Copy link
Member

Related Issues

Fixes #1213.

Purpose

  • Fix endless loop of broken FMUs where error test can't be satisfied.

Approach

  • If integrator CVode in oms::SystemSC::doStep() fails return an error.

  - If integrator CVode in oms::SystemSC::doStep() fails return error
@CLAassistant
Copy link

CLAassistant commented Oct 5, 2023

CLA assistant check
All committers have signed the CLA.

@lochel
Copy link
Member

lochel commented Nov 9, 2024

@AnHeuermann, @arun3688 Could you provide an update on the status of this pull request?

@lochel
Copy link
Member

lochel commented Nov 11, 2024

We can merge this one, but it would be nice to have a test case for it.

@lochel lochel assigned lochel and unassigned AnHeuermann Nov 12, 2024
@lochel lochel changed the base branch from master to maintenance/v2.1 November 15, 2024 08:47
@lochel lochel removed the request for review from arun3688 November 15, 2024 08:47
@lochel lochel merged commit 7bd5b8a into OpenModelica:maintenance/v2.1 Nov 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CVode error doesn't stop simulation / infinite loop
3 participants