MSYS2 change MINGW64 to UCRT64 #1220
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
arun3688
force-pushed
the
msys2-ucrt64
branch
2 times, most recently
from
83ebcb0
to
1829915
Compare
AnHeuermann
commented
Mar 18, 2024
| PATH = "${env.PATH};${env.OMDEV_MSYS}\\${env.MSYSTEM_DIR_PREFIX}\\bin\\;${env.OMDEV_MSYS}\\usr\\bin;C:\\bin\\git\\bin;C:\\bin\\git\\usr\\bin;" | ||
| CC="clang" | ||
| CXX="clang++" | ||
| MSYSTEM = "MINGW64" |
There was a problem hiding this comment.
This should be MSYSTEM = "UCRT64".
|
I think all these were done in #1286, please check. |
yes @AnHeuermann I hope we can close this PR |
|
@AnHeuermann, @adrpo, @arun3688 Could you provide an update on the status of this pull request? |
|
This is implemented by other pull requests and can be closed according to @arun3688. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
For OpenModelica we want to use the newer Universal C Runtime (UCRT) on Windows, see OpenModelica/OpenModelica#10939.
For this it would also be good if OMSimulator can be build with MSYS2 and UCRT64 as well as MINGW64.
Changes
OMDEV_MSYSenvironment variables to Jenkinsfile and build scripts.