-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create oms:snapshot from ssp #961
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lochel
requested changes
Feb 23, 2021
adrpo
force-pushed
the
createsnapshotfromssp
branch
from
February 23, 2021 11:21
9eb3f39
to
5a3e83f
Compare
adrpo
force-pushed
the
createsnapshotfromssp
branch
from
February 23, 2021 11:25
5a3e83f
to
ba22ffa
Compare
adrpo
force-pushed
the
createsnapshotfromssp
branch
from
February 23, 2021 11:35
ba22ffa
to
5249a31
Compare
@adrpo looks promising, thanks for your help! |
Closed
lochel
force-pushed
the
createsnapshotfromssp
branch
from
February 24, 2021 15:55
df52f44
to
0defcc2
Compare
I removed some of my latest commits. Now it should work fine again and we will keep it as a backup for #965. |
lochel
approved these changes
Feb 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We decided to merge it as it is and continue with a few other smaller pull requests to get it in good shape.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The purpose of this PR is to create a
oms:snapshot
internally fromSSP
package, which allows to load all the resources like.ssv, .ssm and signalFilter.xml
directly from oms:snapsshot