export signalFilter to ssp #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arun3688
force-pushed
the
signalfiltertossp
branch
from
559d48a
to
de7d32e
Compare
lochel
reviewed
Mar 12, 2021
lochel
force-pushed
the
signalfiltertossp
branch
from
29895cf
to
f975f15
Compare
lochel
force-pushed
the
signalfiltertossp
branch
from
c05c93a
to
c21a43c
Compare
|
@lochel , This should be merged |
lochel
reviewed
Mar 15, 2021
Comment on lines
+382
to
+386
| else | ||
| { | ||
| // delete ssv node from <oms:snapshot> if flag not set | ||
| snapshot.deleteResourceNode("resources/" + std::string(this->getCref()) + ".ssv"); | ||
| } |
There was a problem hiding this comment.
Why do we generate the node in the first place?
There was a problem hiding this comment.
this is because of the current signature of exportToSSD(pugi::xml_node& node, pugi::xml_node& ssvNode, Snapshot& snapshot), And this should be changed when we restructure the exportToFile to use snapshot interface
4 tasks
This reverts commit 8f73aba.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
#865
Purpose
This PR exports signal filters to an external xml file
"signalFilter.xml"insspwhich is stored in the resources directory and referenced inssdfile. If no signal Filters are used the default signal filter is set to all".*"Example
signalFilter.xml