-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated test FMUs with OpenModelica v1.18.0-dev.192 #999
Conversation
What version of OpenModelica did you use? 1.17.0 is already too old. It should be OMCompiler v1.18.0-dev.171+gc263934f53 or never. |
And did you do the submodule updates on purpose or by mistake? |
Then I'll use todays master.
Dang it... |
- Initial unknowns from OpenModelica FMUs are now correct. Removed warnings from reference results.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with all the warnings gone 😃
There is one change in https://github.com/OpenModelica/OMSimulator/pull/999/files#diff-3e28691a2c7245ed9450a4ec5db2a2633eda524f6c05791acfdacdb50e4e3709L138-R123. |
Which test case is it? Your link doesn't work for me. |
testsuite/OMSimulator/PI_Controller.lua |
I guess you refer to |
AircraftVehicleDemonstrator is failing, but I didn't change that FMUs. |
Those FMUs don't run on 32bit Windows. However, I have no clue why it also failed on 64bit Windows.... |
@AnHeuermann I tested your PR in my computer and the AircraftVehicleDemonstrator worked for me |
Now it worked. Should we merge it? |
Do we have some time limits for the test? The AircraftVehicleDemonstrator test is slow: |
Testing using rtest on windows machines is really very unreliable. rtest hangs sometimes, other issues pop up, etc. |
For example, on windows OMSimulator hanged 20 hours already. In general is perl that hangs running rtest and you need to kill it manually. |
@AnHeuermann I did not measure the time, but in my computer also it took close to 5 minutes to finish |
I think the problem here is more related to numeric. The example finished in both cases, but with slightly different numeric results. So it might be a different boost version or any other lib?! Not really sure though. |
No description provided.