Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

depend on phantomjs_bin to provide the phantomjs binaries #78

Merged
merged 5 commits into from
Jan 11, 2021
Merged

depend on phantomjs_bin to provide the phantomjs binaries #78

merged 5 commits into from
Jan 11, 2021

Commits on Jan 11, 2021

  1. depend on phantomjs_bin to provide the phantomjs binaries this projec… 

    …t needs to run in isolation
    @cutz
    cutz committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    3e0a16e View commit details
    Browse the repository at this point in the history

  2. remove extra line

    @cutz
    cutz committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    72c6c38 View commit details
    Browse the repository at this point in the history

  3. Don't change perms at import time. do it when we invoke if we get a p… 

    …ermission denied error.
    @cutz
    cutz committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    ff4bb33 View commit details
    Browse the repository at this point in the history

  4. cleanup imports. dry

    @cutz
    cutz committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    f700364 View commit details
    Browse the repository at this point in the history

  5. just use the logger now

    @cutz
    cutz committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    0137649 View commit details
    Browse the repository at this point in the history