Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API - create one.vmpool.infoextended #3076

Closed
7 tasks
futzi opened this issue Mar 14, 2019 · 2 comments
Closed
7 tasks

API - create one.vmpool.infoextended #3076

futzi opened this issue Mar 14, 2019 · 2 comments

Comments

@futzi
Copy link
Contributor

futzi commented Mar 14, 2019

Description
In 5.8 the API call one.vmpool.info was changed to return only a subset of information of the XML. This is a good idea in general to speed up the API calls.
The issue is now: If you rely on additional information which is not returned you need additional API calls for each VM the additional information is required for.
This finally increases massively the time for external processes.

Perhaps it is possible to enhance the API in two ways (optionally)

  • Create a one.vmpool.infoextended call which behaves as until 5.6 (return all information). This should be faster anyway if you create the right filters so you reduce the amount of data returned and also the overall number of API calls
  • Alternatively allow adding the required data/xml as parameter

Use case
API driven additional interfaces/tools, monitoring etc.

Interface Changes
API: Add one.vmpool.infoextended call

Additional Context
none

Progress Status

  • Branch created
  • Code committed to development branch
  • Testing - QA
  • Documentation
  • Release notes - resolved issues, compatibility, known issues
  • Code committed to upstream release/hotfix branches
  • Documentation committed to upstream release/hotfix branches
@rsmontero
Copy link
Member

I think the first option may be better. (At least straight-forward to implement)

I don't know the specific workflow of your application, but getting the whole list of VMs will sooner or later impact the response time. So I'd recommend either caching the pool (using the new proposed API call) or using the new search functionality in 5.8. You can list VMs with a specific attribute IP="10.0.0.1" for example, that would probably give you a much sorter list...

See the documentation here.

@futzi
Copy link
Contributor Author

futzi commented Mar 14, 2019

Hi Ruben - yes - I think, option 1 is the better way to go and also easy to be implemented on client side.
We are already caching the lists for a certain time - and using the new filter it has boosted the calls really well - many thanx for this.

al3xhh pushed a commit to al3xhh/one that referenced this issue Mar 27, 2019
    * Add new function dump_extended
    * Add new API call one.vmpool.infoextended
    * Add parameter --extended in the CLI
al3xhh pushed a commit to al3xhh/one that referenced this issue Mar 27, 2019
    * Add new function dump_extended
    * Add new API call one.vmpool.infoextended
    * Add parameter --extended in the CLI
al3xhh pushed a commit to al3xhh/one that referenced this issue Mar 28, 2019
    * Add new function dump_extended
    * Add new API call one.vmpool.infoextended
    * Add parameter --extended in the CLI
al3xhh pushed a commit to al3xhh/one that referenced this issue Mar 28, 2019
    * Add new function dump_extended
    * Add new API call one.vmpool.infoextended
    * Add parameter --extended in the CLI
rsmontero added a commit that referenced this issue Mar 29, 2019
    * Add new function dump_extended
    * Add new API call one.vmpool.infoextended (ruby, JAVA, golang)
    * Add parameter --extended in the CLI for onevm

Co-authored-by: Alejandro Huertas <[email protected]>
rsmontero pushed a commit to OpenNebula/docs that referenced this issue Mar 29, 2019
rsmontero added a commit that referenced this issue Mar 29, 2019
    * Add new function dump_extended
    * Add new API call one.vmpool.infoextended (ruby, JAVA, golang)
    * Add parameter --extended in the CLI for onevm

Co-authored-by: Alejandro Huertas <[email protected]>
(cherry picked from commit 2ed170b)
@al3xhh al3xhh closed this as completed Mar 29, 2019
rsmontero pushed a commit to OpenNebula/docs that referenced this issue Apr 1, 2019
(cherry picked from commit 9d507fe)
al3xhh pushed a commit to al3xhh/one that referenced this issue Apr 5, 2019
rsmontero pushed a commit that referenced this issue Apr 5, 2019
rsmontero pushed a commit that referenced this issue Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants