Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Driver and Message classes in OpenNebula daemon #4936

Closed
7 tasks
paczerny opened this issue Jun 18, 2020 · 1 comment
Closed
7 tasks

Refactor Driver and Message classes in OpenNebula daemon #4936

paczerny opened this issue Jun 18, 2020 · 1 comment
Assignees
@paczerny
Labels
Category: Core & System Priority: Normal
Milestone
Release 6.0

Comments

@paczerny
Copy link
Member

Description
Use communication C++ classes developed for Monitor Daemon in OpenNebula daemon.
Use C++11 features for pointers, function bindings and threads.

Use case
Hopefully better code maintanance

Interface Changes
None

Progress Status

  • Branch created
  • Code committed to development branch
  • Testing - QA
  • Documentation
  • Release notes - resolved issues, compatibility, known issues
  • Code committed to upstream release/hotfix branches
  • Documentation committed to upstream release/hotfix branches
@paczerny paczerny added this to the Release 5.14 milestone Jun 18, 2020
@paczerny paczerny self-assigned this Jun 18, 2020
rsmontero added a commit that referenced this issue Jul 2, 2020
@rsmontero
F #4936: Refactor Driver and Message classes in OpenNebula daemon
7c6b7d9 
co-authored-by: Pavel Czerny <[email protected]>
rsmontero pushed a commit that referenced this issue Jul 2, 2020
@rsmontero
F #4936: Move Driver files to better folders (#59)
93c42d8
rsmontero pushed a commit that referenced this issue Jul 2, 2020
@rsmontero
F #4936: Remove 'using namespace std' from headers (#60)
226bc9d
rsmontero pushed a commit that referenced this issue Jul 2, 2020
@rsmontero
F #4936: Fix valgrind issues (#64)
0ea6cf8
rsmontero added a commit that referenced this issue Jul 5, 2020
@rsmontero
F #4936: oned refactor
43f6458 
    * Remove duplicit methods from NebulaUtil

    * Const correctness

    * Fix minor code quality issues

    * Remove ObjectCollection::clone()

    * Minor SSLUtil interface change

co-authored-by: Pavel Czerný <[email protected]>
rsmontero added a commit that referenced this issue Jul 6, 2020
@rsmontero
F #4936: Fix compilation
f5431c9
rsmontero pushed a commit that referenced this issue Jul 14, 2020
@rsmontero
F #4936: Fix Virtual Router table name (#91)
8bdcd1b
rsmontero added a commit that referenced this issue Jul 27, 2020
@rsmontero
F #4936:Refactor ActionManager and Timers
72d70a2 
co-authored-by: Pavel Czerny <[email protected]>
rsmontero pushed a commit that referenced this issue Aug 12, 2020
@rsmontero
F #4936: Execute listener action outside lock (#148)
9b7c17d
rsmontero added a commit that referenced this issue Sep 14, 2020
@rsmontero
F #4936: Refactor pools to use unique_ptr
56a9f48 
co-authored-by: Pavel Czerný <[email protected]>
rsmontero pushed a commit that referenced this issue Sep 24, 2020
@rsmontero
F #4936: Reduce number of new/delete, use unique_ptr (#212)
c0de774 
* On exit stop RequestManager first

* Use unique_ptr for pointers to Template

* Reduce number of new/delete
rsmontero pushed a commit that referenced this issue Sep 24, 2020
@rsmontero
F #4936: Fix compilation (#217)
6d4e8b8
rsmontero pushed a commit that referenced this issue Sep 24, 2020
@rsmontero
F #4936: Replace long iterator definition by auto (#215)
dd04a9f
@paczerny
Copy link
Member Author

paczerny commented Oct 9, 2020

Done:

  • Refactor Driver classes - new message handler
  • Remove using namespace std from headers
  • const correctness
  • refactor 'for' loops, prefer range based or 'auto' instead of long ::iterator definitions
  • Reduce new/delete by using std::unique_ptr

@paczerny paczerny closed this as completed Oct 9, 2020
rsmontero added a commit that referenced this issue Jan 20, 2021
@rsmontero
F #4936: Refactor Driver and Message classes in OpenNebula daemon
a3d8d4a 
co-authored-by: Pavel Czerny <[email protected]>
rsmontero pushed a commit that referenced this issue Jan 20, 2021
F #4936: Move Driver files to better folders (#59)
cf72a29
rsmontero pushed a commit that referenced this issue Jan 20, 2021
F #4936: Remove 'using namespace std' from headers (#60)
daaf132
rsmontero pushed a commit that referenced this issue Jan 20, 2021
F #4936: Fix valgrind issues (#64)
0292f69
rsmontero added a commit that referenced this issue Jan 20, 2021
@rsmontero
F #4936: oned refactor
5650949 
    * Remove duplicit methods from NebulaUtil

    * Const correctness

    * Fix minor code quality issues

    * Remove ObjectCollection::clone()

    * Minor SSLUtil interface change

co-authored-by: Pavel Czerný <[email protected]>
rsmontero added a commit that referenced this issue Jan 20, 2021
@rsmontero
F #4936: Fix compilation
cedf794
rsmontero pushed a commit that referenced this issue Jan 20, 2021
F #4936: Fix Virtual Router table name (#91)
a9f6385
rsmontero added a commit that referenced this issue Jan 20, 2021
@rsmontero
F #4936:Refactor ActionManager and Timers
325db91 
co-authored-by: Pavel Czerny <[email protected]>
rsmontero pushed a commit that referenced this issue Jan 20, 2021
F #4936: Execute listener action outside lock (#148)
238769f
rsmontero added a commit that referenced this issue Jan 20, 2021
@rsmontero
F #4936: Refactor pools to use unique_ptr
5ce49ed 
co-authored-by: Pavel Czerný <[email protected]>
rsmontero pushed a commit that referenced this issue Jan 20, 2021
F #4936: Reduce number of new/delete, use unique_ptr (#212)
3ea67d3 
* On exit stop RequestManager first

* Use unique_ptr for pointers to Template

* Reduce number of new/delete
rsmontero pushed a commit that referenced this issue Jan 20, 2021
F #4936: Fix compilation (#217)
12d87e7
rsmontero pushed a commit that referenced this issue Jan 20, 2021
F #4936: Replace long iterator definition by auto (#215)
123e08c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paczerny paczerny

Labels
Category: Core & System Priority: Normal
Projects
None yet
Milestone
Release 6.0
Development

No branches or pull requests
1 participant
@paczerny