Could not reconfigure a VM with context disk type=block

[atodorov-storpool]

Description
This is another perspective of issue #6688. Please feel free to merge it although it is regarding another component of of opennebula (the VMM_MAD for KVM).

When a the contextualization CDROM is a block device an extra argument --block should be added to the change-media command used by the vmm/reconfigre script.

To Reproduce

• deploy a VM with context cdrom of type block
• try to reconfigure the VM (update configuration).

Fri Aug 9 10:32:55 2024 [Z0][VMM][I]: Command execution fail (exit code: 1): cat << 'EOT' | /var/tmp/one/vmm/kvm/reconfigure '73b45748-1863-4d19-95ab-42144817190a' 'hda' '/var/lib/one//datastores/0/0/disk.1' 0 u24onekvm2
Fri Aug 9 10:32:55 2024 [Z0][VMM][E]: reconfigure: Command "virsh --connect qemu:///system change-media 73b45748-1863-4d19-95ab-42144817190a hda /var/lib/one//datastores/0/0/disk.1 --insert" failed: error: Failed to complete action insert on media
Fri Aug 9 10:32:55 2024 [Z0][VMM][I]: error: internal error: unable to execute QEMU command 'blockdev-add': 'file' driver requires '/var/lib/one//datastores/0/0/disk.1' to be a regular file
Fri Aug 9 10:32:55 2024 [Z0][VMM][I]: Could not insert CDROM /var/lib/one//datastores/0/0/disk.1 to hda
Fri Aug 9 10:32:55 2024 [Z0][VMM][I]: ExitCode: 1
Fri Aug 9 10:32:55 2024 [Z0][VMM][I]: Failed to execute virtualization driver operation: reconfigure.
Fri Aug 9 10:32:55 2024 [Z0][VMM][E]: UPDATECONF: ERROR: reconfigure: Command "virsh --connect qemu:///system change-media 73b45748-1863-4d19-95ab-42144817190a hda /var/lib/one//datastores/0/0/disk.1 --insert" failed: error: Failed to complete action insert on media error: internal error: unable to execute QEMU command 'blockdev-add': 'file' driver requires '/var/lib/one//datastores/0/0/disk.1' to be a regular file Could not insert CDROM /var/lib/one//datastores/0/0/disk.1 to hda ExitCode: 1

Expected behavior
VM reconfigure should succeed.

Details

• Affected Component: [e.g. Sunstone, Scheduler, or Storage]
• Hypervisor: [e.g. KVM]
• Version: [e.g. 5.4.12 or development]

Additional context
from virsh change-media help

virsh # help change-media
  NAME
    change-media - Change media of CD or floppy drive

  SYNOPSIS
    change-media <domain> <path> [--source <string>] [--eject] [--insert] [--update] [--current] [--live] [--config] [--force] [--print-xml] [--block]

  DESCRIPTION
    Change media of CD or floppy drive.

  OPTIONS
    [--domain] <string>  domain name, id or uuid
    [--path] <string>  Fully-qualified path or target of disk device
    --source <string>  source of the media
    --eject          Eject the media
    --insert         Insert the media
    --update         Update the media
    --current        can be either or both of --live and --config, depends on implementation hypervisor driver
    --live           alter live configuration of running domain
    --config         alter persistent configuration, effect observed on next boot
    --force          force media changing
    --print-xml      print XML document rather than change media
    --block          source media is a block device

it should be relatively easy to fix in the bash script by testing the $ISO_PATH argument and appending --block if it is recognized as a block device.

Progress Status

• Code committed
• Testing - QA
• Documentation (Release notes - resolved issues, compatibility, known issues)