Check VMGroupRole in VMGroupXML.cc

[sminux]

Description
Return value of a function 'VMGroupRoles::get' is dereferenced at VMGroupXML.cc:

one/src/scheduler/src/pool/VMGroupXML.cc

Lines 177 to 179 in 1ae1de4

	VMGroupRole * r = roles.get(i);
	const std::set<int>& vms = r->get_vms();

without checking for NULL, but it is usually checked for this function (4 of 5).
Like that:

one/src/scheduler/src/pool/VMGroupXML.cc

Lines 428 to 433 in 1ae1de4

	VMGroupRole * r = roles.get(i);
	if ( r == 0 )
	{
	continue;
	}

Details

• Affected Component: [e.g. Sunstone, Scheduler, or Storage]
• Hypervisor: KVM
• Version: 6.9.8 or development

Progress Status

• Code committed
• Testing - QA
• Documentation (Release notes - resolved issues, compatibility, known issues)

[rsmontero]

Merged in 1607b4a