Feature #1454: OpenNebula to OpenNebula drivers #1743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
January 18, 2018 15:59
rsmontero
commented
Feb 14, 2018
share/etc/oned.conf
Outdated
| ARGUMENTS = "-t 15 -r 0 one", | ||
| TYPE = "xml", | ||
| KEEP_SNAPSHOTS = "no", | ||
| IMPORTED_VMS_ACTIONS = "terminate, terminate-hard, hold, release, suspend, |
There was a problem hiding this comment.
Driver actually accept import, this list of actions needs to be consistent with the actions implemented
| @@ -722,7 +722,8 @@ static const map<std::string, unsigned int> MAX_HOST_VAR_SIZES = { | |||
| {"EC2_SECRET", 41}, | |||
| {"AZ_ID", 41}, | |||
| {"AZ_CERT", 3130}, | |||
| {"VCENTER_PASSWORD", 22} | |||
| {"VCENTER_PASSWORD", 22}, | |||
| {"ONE_PASSWORD", 22} | |||
There was a problem hiding this comment.
22 is the password limit, it may be increased for OpenNebula, that does not have this limitation. OpenNebula has a x509 driver so 8192 could be enough for that
| #!/usr/bin/env ruby | ||
|
|
||
| # -------------------------------------------------------------------------- # | ||
| # Copyright 2002-2016, OpenNebula Project, OpenNebula Systems # |
| @@ -32,7 +32,7 @@ def create(template_json) | |||
| host_hash['cluster_id'].to_i) | |||
| delete_values = ['name', 'im_mad', 'vm_mad', 'cluster_id'] | |||
|
|
|||
| template_str = hash_to_str(host_hash, delete_values) | |||
| template_str = template_to_str(host_hash, delete_values) | |||
There was a problem hiding this comment.
Why is this change needed, does it not break other things?
src/vmm_mad/remotes/one/attach_disk
Outdated
| #!/bin/bash | ||
|
|
||
| # -------------------------------------------------------------------------- # | ||
| # Copyright 2002-2016, OpenNebula Project, OpenNebula Systems # |
src/vmm_mad/remotes/one/cancel
Outdated
| #!/usr/bin/env ruby | ||
|
|
||
| # -------------------------------------------------------------------------- # | ||
| # Copyright 2002-2016, OpenNebula Project, OpenNebula Systems # |
| @@ -0,0 +1,643 @@ | |||
| #!/usr/bin/env ruby | |||
| # -------------------------------------------------------------------------- # | |||
| # Copyright 2002-2016, OpenNebula Project, OpenNebula Systems # | |||
|
|
||
| secret = "#{region['user']}:#{region['password']}" | ||
|
|
||
| # This breaks the CLI SSL support for Ruby 1.8.7, but is necessary |
There was a problem hiding this comment.
Can we get rid of this?
| end | ||
|
|
||
| # TODO move this method to a OneGate library. See ec2_driver.rb | ||
| def generate_onegate_token(xml) |
| state = "" | ||
|
|
||
| state = case vm.state_str | ||
| when "INIT" |
There was a problem hiding this comment.
Maybe better to use a compact form for the same mapping.
when "INIT" || "PENDING" || "HOLD"
VM_STATE[:active]
Also review with states in VirtualMachine.h that we are not missing any new state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.