Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LXD market importer #3156

Merged
merged 3 commits into from
Apr 2, 2019
Merged

Fix LXD market importer #3156

merged 3 commits into from
Apr 2, 2019

Conversation

dann1
Copy link
Contributor

@dann1 dann1 commented Apr 1, 2019

Replaces #3138

  • centos 6 and 7 enable sshd at startup after installing openssh-server
  • alpine was missing curl, so it couldn't get the context package
  • packages were being left on container /root/ directory

Since we won't add ssh dependency for alpine on context-package, we could install openssh here on alpine case.

@dann1 dann1 requested a review from rsmontero April 1, 2019 08:32
@rsmontero
Copy link
Member

rsmontero commented Apr 1, 2019

Consider also my comment to #3138 about custom package installation. This commit does not include ssh installation?

@dann1
Copy link
Contributor Author

dann1 commented Apr 1, 2019

Consider also my comment to #3138 about custom package installation. This commit does not include ssh installation?

Done, we had openssh stated but it was confirmed as a missing dep for context package. I guess until we release a new context version we can state here the missing deps such as openssh and dbus for ubuntu.

@vholer do you think stating openssh here on alpine it is correct, taking into account my unmerged packages PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants