Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

F-115: VM: enable volatile disks #155

Merged
merged 5 commits into from
Dec 2, 2021
Merged

F-115: VM: enable volatile disks #155

merged 5 commits into from
Dec 2, 2021

Conversation

treywelsh
Copy link
Collaborator

@treywelsh treywelsh commented Sep 10, 2021 •
edited
Loading

No description provided.

@treywelsh treywelsh changed the title WIP: F-115: VM: enable volatile disks F-115: VM: enable volatile disks Sep 20, 2021
jaypif
jaypif requested changes Sep 24, 2021
View reviewed changes
opennebula/resource_opennebula_virtual_machine.go Outdated Show resolved Hide resolved
opennebula/resource_opennebula_virtual_machine.go Outdated Show resolved Hide resolved
opennebula/shared_schemas.go Outdated Show resolved Hide resolved
website/docs/r/template.html.markdown Outdated Show resolved Hide resolved
website/docs/r/template.html.markdown Outdated Show resolved Hide resolved
website/docs/r/template.html.markdown Outdated Show resolved Hide resolved
website/docs/r/virtual_machine.html.markdown Outdated Show resolved Hide resolved
jaypif
jaypif requested changes Sep 24, 2021
View reviewed changes
opennebula/shared_schemas.go Outdated Show resolved Hide resolved
@treywelsh treywelsh linked an issue Sep 28, 2021 that may be closed by this pull request
template: volatile disk #115
Closed
@treywelsh
Copy link
Collaborator Author

Update with review comments, miss acceptance tests

@treywelsh
Copy link
Collaborator Author

treywelsh commented Oct 25, 2021 •
edited
Loading

During testing, I realized thatConflictsWith can't be used in nested parts like disks and lists: hashicorp/terraform-plugin-sdk#71

I'll try to replace this at apply time until future improvements of the terraform-sdk.
The problem is that the user will be asked for apply (yes/no), and after the code will fail.
This may be annoying in automated environments ?

@treywelsh treywelsh force-pushed the F-115-enable-volatile-disks branch 2 times, most recently from 7d53db2 to 0a544bf Compare November 10, 2021 13:57
jaypif
jaypif requested changes Nov 19, 2021
View reviewed changes
opennebula/shared_schemas.go Outdated Show resolved Hide resolved
website/docs/r/template.html.markdown Outdated Show resolved Hide resolved
@treywelsh
Copy link
Collaborator Author

Changes applied after review

@treywelsh treywelsh force-pushed the F-115-enable-volatile-disks branch 2 times, most recently from e8f4dc7 to fcdfc4e Compare December 2, 2021 15:18
@treywelsh treywelsh merged commit e7f97dd into OpenNebula:master Dec 2, 2021
@treywelsh treywelsh mentioned this pull request Apr 29, 2022
Closed
@treywelsh treywelsh mentioned this pull request May 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaypif jaypif jaypif approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

template: volatile disk
2 participants
@treywelsh @jaypif