Improve Add/Attach performance for large graphs #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed since any changes to them would have already been discovered
…rf (calls contains on HashSet instead of Enumerable) and smarter enum checks due to pattern matchning
Daniel-Svensson
changed the title
Daniel-Svensson
commented
Feb 6, 2024
src/OpenRiaServices.Client/Test/Client.Test/Data/EntityContainerTests.cs
Outdated
Show resolved
Hide resolved
* Use result of HashSet.Add instead of checking Contains before Add * Make ListCollectionViewProxy smarter * remove IndexOf from Add for O(1) instead of O(n) performance * Contains use hashSet contains instead of IndeOf for O(1) instead of O(n) performance * Remove argument range check
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes adding n entities to an EntityCollection or similar roughly O(n) instead of O(n²)
Commit 1-2 are based on perf data from #450
Commit 3 is mostly code cleanup, with some minor perf improvements
The performance for adding 20 000 entities to an EntityCollection is improved by more than 100x (just for commit 2)
Commit 2 performance difference: