Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EntityAssociationAttribute Step2 #513

Merged

Conversation

Daniel-Svensson
Copy link
Member

@Daniel-Svensson Daniel-Svensson commented Jun 11, 2024

  1. Change EntityAssociationAttribute namespace to System.ComponentModel.DataAnnotations
    • This will match other attributes such as [Composition] as well as the AssociationAttribute is should replace
  2. Add a constructor taking 2 strings for the case where the key is a single member
  3. Update code generation to use new constructor when possible (EntityAssociationAttributeBuilder)
  4. Update baselines

@Daniel-Svensson Daniel-Svensson marked this pull request as ready for review June 11, 2024 19:22
@Daniel-Svensson Daniel-Svensson added this to the 5.5.0 milestone Jun 11, 2024
@Daniel-Svensson Daniel-Svensson linked an issue Jun 11, 2024 that may be closed by this pull request
Copy link

sonarcloud bot commented Jun 11, 2024

@Daniel-Svensson Daniel-Svensson merged commit 6e0bcfc into OpenRIAServices:main Jun 12, 2024
5 checks passed
@Daniel-Svensson Daniel-Svensson deleted the associationAttribute_v2 branch June 12, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

association attribute is obsolete
2 participants