-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Meta Trait: Trait Count #84
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vickygos
changed the title
Adding Meta Trait: Trait Count for Rarity Calculation
Adding Meta Trait: Trait Count
Oct 14, 2022
I modified the PR text a bit. |
vickygos
requested review from
impreso,
theelderbeever,
dadashi and
grantli-os
October 15, 2022 02:22
theelderbeever
requested changes
Oct 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was a big one... A couple comments with possible additions and nits. Nothing major.
grantli-os
approved these changes
Oct 17, 2022
theelderbeever
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Trait Count to OpenRarity
We are automatically adding TraitCount as a meta trait upon Collection initialization so that the OpenRarity ranking and scoring algorithm takes into consideration trait count as an attribute to impact ranking for all collections. We will not modify open rarity scoring or ranking algorithm directly in any form.
For more detailed information and analysis, please review this blog post -https://mirror.xyz/openrarity.eth/oNo7AmgXopMCKq95gv_Xe0p5pKQ_qHWKzTV11DpFxgE
Definition of Trait Count
TraitCount is defined to be the sum of unique traits an asset has with a non-empty value
(“”, “none”, None)
Methodology
Upon
Collection
initialization, we will modify thetokens
input by adding in a newStringAttribute
to the tokens' metadata with:attribute.name
=“meta_trait:trait_count”
attribute.value
= token.trait_count()