Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes needed in order for mypy to pass
This also fixes a few bugs and some incorrect type hints.
Bugs:
open_rarity/models/token_metadata.py
was usingdatetime.fromtimestamp
but should have beendatetime.datetime.fromtimestamp
open_rarity/resolver/testset_resolver.py
the methodresolve_collection_data
was returning a dict rather than a list as the types and docs impliedBug left unresolved:
open_rarity/resolver/testset_resolver.py
theextract_rank
method assumes the token_identifier has a token_id field, but this is not true forSolanaMintAddressTokenIdentifier
. I'm ignoring the type error for now