Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fixes #95

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Small fixes #95

merged 1 commit into from
Oct 28, 2022

Conversation

vickygos
Copy link
Contributor

  • Skips external rarity sniffer test that depends on external API
  • Adds a warning for when metadata is missing during resolver

@vickygos vickygos marked this pull request as ready for review October 28, 2022 18:13
impreso
impreso approved these changes Oct 28, 2022
View reviewed changes
Copy link
Contributor

@impreso impreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vickygos vickygos merged commit bf53aef into main Oct 28, 2022
@vickygos vickygos deleted the vicky/skip_external_resolver_tests branch October 28, 2022 21:52
@vickygos vickygos restored the vicky/skip_external_resolver_tests branch November 2, 2022 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@impreso impreso impreso approved these changes

@grantli-os grantli-os grantli-os approved these changes

@theelderbeever theelderbeever Awaiting requested review from theelderbeever

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vickygos @impreso @grantli-os