Update pam_p11.c - key_login() always succeeded #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
key_login always succeed even if PIN input was incorrect. r = PAM_SUCCESS prior to key_login and didn't get changed to a failure if key_login failed.
|
I think PAM_CRED_INSUFFICIENT ("Insufficient credentials to access authentication data.") should be more appropriate, shouldn't it? |
Updated PAM error to PAM_CRED_INSUFFICIENT as it's more appropriate than PAM_AUTH_ERR
|
I just used the same as was used prior to key_login() and key_verify() being split into separate checks. PAM_CRED_INSUFFICIENT does feel correct though. |
|
thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
key_login always succeeded even if PIN input was incorrect. r = PAM_SUCCESS set prior to key_login() and didn't get changed to a failure if key_login() failed.