delete folder vendor in git #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pak @eddieridwan mohon untuk di merge pr ini. |
|
@ralfiannor , maaf baru sempat kembali memperhatikan OpenDK. Terima kasih PR-nya. Tapi setelah saya coba, banyak yg tidak jalan, karena ada yg kurang setelah folder |
|
Bung @ralfiannor, apakah anda sempat membantu memperbaiki OpenDK? Kalau sempat, saya berikan anda akses bisa push langsung ke repo OpenDK, untuk mempercepat. |
|
@ralfiannor , penghapusan folder Karena itu, pull request ini akan ditutup. Tapi silakan buka lagi kalau ada yg perlu ditambah. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sepengetahuan saya folder vendor adalah hasil build ketika kita menjalankan perintah "composer install". Nah perintah itu harusnya dilakukan di local komputer masing-masing sehingga apa yang kita download dan upload di git hanya source code yang berisi core nya saja.
Untuk masalah https://github.com/OpenSID/OpenDK/wiki/Install-di-cPanel sebaiknya kita buat halaman release dimana disana berisi file zip aplikasi yang sudah rilis bukan download source code untuk developer. Seperti pada OpenSID https://github.com/OpenSID/OpenSID/releases