feat(reasoner): support spo inference #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fishjoy
requested review from
youdonghai,
royzhao,
yixianlzz,
wangsff and
baifuyu
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has checked 1692 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 1584 | 2 | 106 | 0 |
Click to see the invalid file list
- reasoner/thinker/src/test/java/com/antgroup/openspg/reasoner/thinker/RuleGenerator.java
- reasoner/thinker/src/test/java/com/antgroup/openspg/reasoner/thinker/logic/rule/QlExpressTest.java
Use this command to fix any missing license headers
```bash
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix
</details>
| @@ -0,0 +1,149 @@ | |||
| package com.antgroup.openspg.reasoner.thinker; | |||
There was a problem hiding this comment.
Suggested change
| package com.antgroup.openspg.reasoner.thinker; | |
| /* | |
| * Copyright 2023 OpenSPG Authors | |
| * | |
| * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except | |
| * in compliance with the License. You may obtain a copy of the License at | |
| * | |
| * http://www.apache.org/licenses/LICENSE-2.0 | |
| * | |
| * Unless required by applicable law or agreed to in writing, software distributed under the License | |
| * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express | |
| * or implied. | |
| */ | |
| package com.antgroup.openspg.reasoner.thinker; |
| @@ -0,0 +1,70 @@ | |||
| package com.antgroup.openspg.reasoner.thinker.logic.rule; | |||
There was a problem hiding this comment.
Suggested change
| package com.antgroup.openspg.reasoner.thinker.logic.rule; | |
| /* | |
| * Copyright 2023 OpenSPG Authors | |
| * | |
| * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except | |
| * in compliance with the License. You may obtain a copy of the License at | |
| * | |
| * http://www.apache.org/licenses/LICENSE-2.0 | |
| * | |
| * Unless required by applicable law or agreed to in writing, software distributed under the License | |
| * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express | |
| * or implied. | |
| */ | |
| package com.antgroup.openspg.reasoner.thinker.logic.rule; |
wangsff
reviewed
Jun 12, 2024
| @@ -40,13 +40,8 @@ public TreeLogger(String currentNodeName) { | |||
| } | |||
|
|
|||
| public TreeLogger log(Object msg) { | |||
There was a problem hiding this comment.
每个Treelogger都是当前Node记录的信息，所以不需要append。最后打印拼接时才append
| return instance; | ||
| } | ||
| synchronized (QlExpressRunner.class) { | ||
| QlExpressRunner runner = new QlExpressRunner(); |
There was a problem hiding this comment.
单例模式，synchronized里面还需做一次if判断
youdonghai
approved these changes
Jun 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.